Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bullet style support #48

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

Bibz87
Copy link
Contributor

@Bibz87 Bibz87 commented Feb 5, 2025

This adds support for customizing the bullet point character used in unordered lists.

@Bibz87 Bibz87 marked this pull request as ready for review February 5, 2025 18:23
@Bibz87 Bibz87 marked this pull request as draft February 5, 2025 18:36
@Bibz87 Bibz87 marked this pull request as ready for review February 5, 2025 19:02
@oscarotero
Copy link
Owner

Hmm, is this really necessary? Why do you want to change the bullet style?

@Bibz87
Copy link
Contributor Author

Bibz87 commented Feb 6, 2025

Our markdownlint's unordered list style rule (MD004) is set to asterisk, so a changelog generated with the tool would fail lint checks. The reason I propose this change is to have the correct list style built-in instead of having to find & replace after generating the changelog.

That's the only reason.

@oscarotero oscarotero merged commit a2440a0 into oscarotero:master Feb 6, 2025
1 check passed
@oscarotero
Copy link
Owner

I think dash is the most common style (and easier to write), but okay. Thanks!

@Bibz87 Bibz87 deleted the bullet-style-support branch February 7, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants